Fix Windows CI: update conan.cmake and disable unit tests as temporary workaround for OOM issues #6930

SiarheiFedartsou · 2024-06-06T19:22:23Z

It seems compiler on Windows CI image was silently updated... /~https://github.com/Project-OSRM/osrm-backend/actions/runs/9406402190/job/25909804011

Benchmark Results

Benchmark	Base	PR
alias	aliased u32: 1171.92 plain u32: 1152.72 aliased double: 1211.81 plain double: 1188.42	aliased u32: 1154.91 plain u32: 1156.47 aliased double: 1188.07 plain double: 1193.56
e2e_match_ch	Total: 2948.2903480529785ms Min time: 2.417325973510742ms Mean time: 22.50603319124411ms Median time: 17.604351043701172ms 95th percentile: 71.58946990966797ms 99th percentile: 85.05244255065912ms Max time: 96.44842147827148ms	Total: 2916.4178371429443ms Min time: 2.3775100708007812ms Mean time: 22.262731581243848ms Median time: 17.18449592590332ms 95th percentile: 71.29311561584473ms 99th percentile: 85.56318283081053ms Max time: 94.80023384094238ms
e2e_match_mld	Total: 2062.250852584839ms Min time: 2.0775794982910156ms Mean time: 15.742372920494953ms Median time: 9.059667587280273ms 95th percentile: 49.502015113830566ms 99th percentile: 58.540248870849574ms Max time: 67.98863410949707ms	Total: 2066.682815551758ms Min time: 2.096414566040039ms Mean time: 15.77620469886838ms Median time: 9.074687957763672ms 95th percentile: 50.968289375305176ms 99th percentile: 57.54888057708737ms Max time: 66.68734550476074ms
e2e_nearest_ch	Total: 1366.6179180145264ms Min time: 1.1627674102783203ms Mean time: 1.3666179180145264ms Median time: 1.2807846069335938ms 95th percentile: 1.7758727073669431ms 99th percentile: 1.8318533897399902ms Max time: 1.9807815551757812ms	Total: 1372.6558685302734ms Min time: 1.1446475982666016ms Mean time: 1.3726558685302734ms Median time: 1.2854337692260742ms 95th percentile: 1.7901062965393066ms 99th percentile: 1.8684935569763184ms Max time: 1.9676685333251953ms
e2e_nearest_mld	Total: 1355.2865982055664ms Min time: 1.127004623413086ms Mean time: 1.3552865982055664ms Median time: 1.2688636779785156ms 95th percentile: 1.7658352851867676ms 99th percentile: 1.830909252166748ms Max time: 1.9135475158691406ms	Total: 1359.4236373901367ms Min time: 1.150369644165039ms Mean time: 1.3594236373901367ms Median time: 1.2729167938232422ms 95th percentile: 1.7855644226074219ms 99th percentile: 1.8423247337341309ms Max time: 1.9216537475585938ms
e2e_route_ch	Total: 3323.6308097839355ms Min time: 1.397848129272461ms Mean time: 3.3236308097839355ms Median time: 3.3500194549560547ms 95th percentile: 4.373478889465332ms 99th percentile: 4.873156547546387ms Max time: 5.348682403564453ms	Total: 3353.3589839935303ms Min time: 1.4307498931884766ms Mean time: 3.3533589839935303ms Median time: 3.3876895904541016ms 95th percentile: 4.377889633178711ms 99th percentile: 4.870200157165527ms Max time: 5.796194076538086ms
e2e_route_mld	Total: 3840.7769203186035ms Min time: 1.3613700866699219ms Mean time: 3.8407769203186035ms Median time: 3.8878917694091797ms 95th percentile: 5.317449569702148ms 99th percentile: 5.764913558959961ms Max time: 6.606817245483398ms	Total: 3784.6667766571045ms Min time: 1.3654232025146484ms Mean time: 3.7846667766571045ms Median time: 3.8149356842041016ms 95th percentile: 5.2040815353393555ms 99th percentile: 5.77890157699585ms Max time: 6.380796432495117ms
e2e_table_ch	Total: 16445.453882217407ms Min time: 2.1889209747314453ms Mean time: 16.445453882217407ms Median time: 15.662312507629395ms 95th percentile: 30.093610286712643ms 99th percentile: 31.243255138397217ms Max time: 33.2028865814209ms	Total: 16855.68904876709ms Min time: 2.2029876708984375ms Mean time: 16.85568904876709ms Median time: 16.205191612243652ms 95th percentile: 30.828988552093506ms 99th percentile: 32.6899528503418ms Max time: 36.53883934020996ms
e2e_table_mld	Total: 64992.84219741821ms Min time: 4.218816757202148ms Mean time: 64.99284219741821ms Median time: 61.6685152053833ms 95th percentile: 125.92855691909789ms 99th percentile: 135.02317190170288ms Max time: 143.13697814941406ms	Total: 64967.54264831543ms Min time: 4.517078399658203ms Mean time: 64.96754264831543ms Median time: 61.45322322845459ms 95th percentile: 125.55983066558838ms 99th percentile: 134.70858097076416ms Max time: 143.4025764465332ms
e2e_trip_ch	Total: 11385.282278060913ms Min time: 1.8186569213867188ms Mean time: 11.385282278060913ms Median time: 10.976433753967285ms 95th percentile: 19.488930702209473ms 99th percentile: 21.25053882598877ms Max time: 22.016525268554688ms	Total: 11690.971612930298ms Min time: 1.5816688537597656ms Mean time: 11.690971612930298ms Median time: 11.211037635803223ms 95th percentile: 20.035159587860107ms 99th percentile: 21.71929359436035ms Max time: 23.308277130126953ms
e2e_trip_mld	Total: 18514.16826248169ms Min time: 1.7778873443603516ms Mean time: 18.51416826248169ms Median time: 18.216729164123535ms 95th percentile: 29.77352142333984ms 99th percentile: 31.47693157196045ms Max time: 33.908843994140625ms	Total: 18379.89902496338ms Min time: 1.7948150634765625ms Mean time: 18.37989902496338ms Median time: 18.059372901916504ms 95th percentile: 29.63191270828247ms 99th percentile: 31.572368144989014ms Max time: 32.866477966308594ms
json-render	String: 6.59646ms Stringstream: 9.30226ms Vector: 6.9316ms	String: 6.65803ms Stringstream: 9.36392ms Vector: 6.98215ms
match_ch	Default radius: 4.42566ms/req at 82 coordinate 0.0539714ms/coordinate Radius 5m: 4.40111ms/req at 82 coordinate 0.0536721ms/coordinate Radius 10m: 15.0884ms/req at 82 coordinate 0.184005ms/coordinate Radius 15m: 36.8243ms/req at 82 coordinate 0.449076ms/coordinate Radius 30m: 313.188ms/req at 82 coordinate 3.81936ms/coordinate	Default radius: 4.41137ms/req at 82 coordinate 0.0537972ms/coordinate Radius 5m: 4.4017ms/req at 82 coordinate 0.0536793ms/coordinate Radius 10m: 15.0794ms/req at 82 coordinate 0.183895ms/coordinate Radius 15m: 36.8351ms/req at 82 coordinate 0.449209ms/coordinate Radius 30m: 312.972ms/req at 82 coordinate 3.81673ms/coordinate
match_mld	Default radius: 2.77654ms/req at 82 coordinate 0.0338603ms/coordinate Radius 5m: 2.80799ms/req at 82 coordinate 0.0342438ms/coordinate Radius 10m: 10.1642ms/req at 82 coordinate 0.123954ms/coordinate Radius 15m: 25.8945ms/req at 82 coordinate 0.315787ms/coordinate Radius 30m: 303.979ms/req at 82 coordinate 3.70706ms/coordinate	Default radius: 2.96465ms/req at 82 coordinate 0.0361542ms/coordinate Radius 5m: 2.94964ms/req at 82 coordinate 0.0359712ms/coordinate Radius 10m: 11.133ms/req at 82 coordinate 0.135768ms/coordinate Radius 15m: 28.6986ms/req at 82 coordinate 0.349983ms/coordinate Radius 30m: 303.662ms/req at 82 coordinate 3.7032ms/coordinate
osrm_contract	Time: 95.52s Peak RAM: 185.42MB	Time: 94.40s Peak RAM: 185.63MB
osrm_customize	Time: 1.30s Peak RAM: 115.07MB	Time: 1.32s Peak RAM: 115.06MB
osrm_extract	Time: 12.23s Peak RAM: 414.71MB	Time: 12.47s Peak RAM: 403.03MB
osrm_partition	Time: 2.21s Peak RAM: 148.62MB	Time: 2.31s Peak RAM: 149.68MB
packedvector	random write: std::vector 11187 ms util::packed_vector 74374.5 ms slowdown: 6.64832 random read: std::vector 8648.69 ms util::packed_vector 30331.3 ms slowdown: 3.50704	random write: std::vector 11279.9 ms util::packed_vector 74629.1 ms slowdown: 6.61611 random read: std::vector 11091.5 ms util::packed_vector 31013.6 ms slowdown: 2.79617
route_ch	1000 routes, 3 coordinates, no alternatives, overview=full, steps=true 509.746ms 0.509746ms/req 1000 routes, 2 coordinates, no alternatives, overview=full, steps=true 350.473ms 0.350473ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true 626.126ms 0.626126ms/req 1000 routes, 3 coordinates, no alternatives, overview=false, steps=false 153.48ms 0.15348ms/req 1000 routes, 2 coordinates, no alternatives, overview=false, steps=false 97.5078ms 0.0975078ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false 132.669ms 0.132669ms/req 1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750 150.212ms 0.150212ms/req 1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750 97.3822ms 0.0973822ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750 131.921ms 0.131921ms/req	1000 routes, 3 coordinates, no alternatives, overview=full, steps=true 511.715ms 0.511715ms/req 1000 routes, 2 coordinates, no alternatives, overview=full, steps=true 352.969ms 0.352969ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true 626.764ms 0.626764ms/req 1000 routes, 3 coordinates, no alternatives, overview=false, steps=false 151.548ms 0.151548ms/req 1000 routes, 2 coordinates, no alternatives, overview=false, steps=false 97.7536ms 0.0977536ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false 132.259ms 0.132259ms/req 1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750 151.151ms 0.151151ms/req 1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750 97.5273ms 0.0975273ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750 132.379ms 0.132379ms/req
route_mld	1000 routes, 3 coordinates, no alternatives, overview=full, steps=true 639.283ms 0.639283ms/req 1000 routes, 2 coordinates, no alternatives, overview=full, steps=true 436.25ms 0.43625ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true 812.211ms 0.812211ms/req 1000 routes, 3 coordinates, no alternatives, overview=false, steps=false 261.041ms 0.261041ms/req 1000 routes, 2 coordinates, no alternatives, overview=false, steps=false 159.992ms 0.159992ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false 284.667ms 0.284667ms/req 1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750 257.605ms 0.257605ms/req 1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750 158.876ms 0.158876ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750 283.532ms 0.283532ms/req	1000 routes, 3 coordinates, no alternatives, overview=full, steps=true 638.32ms 0.63832ms/req 1000 routes, 2 coordinates, no alternatives, overview=full, steps=true 435.18ms 0.43518ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=full, steps=true 806.769ms 0.806769ms/req 1000 routes, 3 coordinates, no alternatives, overview=false, steps=false 260.83ms 0.26083ms/req 1000 routes, 2 coordinates, no alternatives, overview=false, steps=false 160.76ms 0.16076ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false 281.477ms 0.281477ms/req 1000 routes, 3 coordinates, no alternatives, overview=false, steps=false, radius=750 257.202ms 0.257202ms/req 1000 routes, 2 coordinates, no alternatives, overview=false, steps=false, radius=750 159.85ms 0.15985ms/req 1000 routes, 2 coordinates, 3 alternatives, overview=false, steps=false, radius=750 281.405ms 0.281405ms/req
rtree	1 result: 207.869ms -> 0.0207869 ms/query 10 results: 242.434ms -> 0.0242434 ms/query	1 result: 208.745ms -> 0.0208745 ms/query 10 results: 244.486ms -> 0.0244486 ms/query

SiarheiFedartsou · 2024-06-06T19:23:20Z

cmake/conan.cmake

@@ -55,7 +55,7 @@ function(_get_msvc_ide_version result)
        set(${result} 15 PARENT_SCOPE)
    elseif(NOT MSVC_VERSION VERSION_LESS 1920 AND MSVC_VERSION VERSION_LESS 1930)
        set(${result} 16 PARENT_SCOPE)
-    elseif(NOT MSVC_VERSION VERSION_LESS 1930 AND MSVC_VERSION VERSION_LESS 1940)
+    elseif(NOT MSVC_VERSION VERSION_LESS 1930 AND MSVC_VERSION VERSION_LESS 1950)


Just applies this change conan-io/cmake-conan@6e5369d

Actually it is better to upgrade to Conan 2, but it would take much more time :)

SiarheiFedartsou · 2024-06-09T07:09:50Z

I decided to merge only fix of Conan-related things. Another issue is that now we have OOM when building tests, so I disabled tests for the time being and created ticket for that... #6935

Fix Windows CI

d256fd0

SiarheiFedartsou force-pushed the sf-fix-windows branch from 667415f to d256fd0 Compare June 6, 2024 19:22

SiarheiFedartsou commented Jun 6, 2024

View reviewed changes

SiarheiFedartsou marked this pull request as ready for review June 6, 2024 19:33

SiarheiFedartsou requested a review from DennisOSRM June 6, 2024 19:33

DennisOSRM approved these changes Jun 6, 2024

View reviewed changes

SiarheiFedartsou added 2 commits June 6, 2024 22:19

wip

3d7c3db

wip

49e34fe

SiarheiFedartsou force-pushed the sf-fix-windows branch from f8f664c to 49e34fe Compare June 7, 2024 05:15

SiarheiFedartsou added 21 commits June 7, 2024 08:57

wip

82c62af

wip

d214f52

wip

8161ba9

wip

ba117af

wip

d9e5a3d

wip

2b972f5

wip

f36746f

wip

7cfca85

wip

75521c7

wip

acd1bc5

wip

344d254

wip

ef70c23

wip

7e1fa53

wip

2ca298a

wip

49ea9f0

wip

7ab9b7b

wip

dd264c5

wip

bb812ab

wip

c762789

wip

fac531c

wip

0fb11a6

SiarheiFedartsou added 9 commits June 7, 2024 18:22

wip

90cd6b0

wip

4b05f30

wip

f95ce7f

wip

0cbffb3

wip

82c3d62

wip

68f8be6

wip

8a472b3

wip

01996f3

wip

d6f42b4

SiarheiFedartsou mentioned this pull request Jun 8, 2024

Windows CI job goes out of memory when building tests #6935

Open

SiarheiFedartsou changed the title ~~Fix Windows CI~~ Fix Windows CI: update conan.cmake and disable building unit tests as temporary workaround for OOM issues Jun 8, 2024

SiarheiFedartsou added 9 commits June 8, 2024 11:55

wip

f560b93

wip

9a4aaaa

wip

5b9b5a5

wip

6e0827c

wip

d23a6b3

wip

7dfe267

wip

5cdc0b9

wip

2f5418e

Merge branch 'master' into sf-fix-windows

70e7568

SiarheiFedartsou changed the title ~~Fix Windows CI: update conan.cmake and disable building unit tests as temporary workaround for OOM issues~~ Fix Windows CI: update conan.cmake and disable unit tests as temporary workaround for OOM issues Jun 8, 2024

SiarheiFedartsou force-pushed the sf-fix-windows branch from c0a2212 to 70e7568 Compare June 8, 2024 20:30

SiarheiFedartsou added 4 commits June 8, 2024 22:32

wip

8f4c222

Merge branch 'master' into sf-fix-windows

339c2ac

wip

fa7b8e6

wip

5598c6d

SiarheiFedartsou mentioned this pull request Jun 9, 2024

Replace boost::filesystem with std #6432

Merged

SiarheiFedartsou merged commit 0cbb23a into master Jun 9, 2024
20 checks passed

SiarheiFedartsou deleted the sf-fix-windows branch June 9, 2024 07:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Windows CI: update conan.cmake and disable unit tests as temporary workaround for OOM issues #6930

Fix Windows CI: update conan.cmake and disable unit tests as temporary workaround for OOM issues #6930

SiarheiFedartsou commented Jun 6, 2024 •

edited by github-actions bot

Loading

SiarheiFedartsou Jun 6, 2024

SiarheiFedartsou Jun 6, 2024

SiarheiFedartsou commented Jun 9, 2024

Fix Windows CI: update conan.cmake and disable unit tests as temporary workaround for OOM issues #6930

Fix Windows CI: update conan.cmake and disable unit tests as temporary workaround for OOM issues #6930

Conversation

SiarheiFedartsou commented Jun 6, 2024 • edited by github-actions bot Loading

Benchmark Results

SiarheiFedartsou Jun 6, 2024

Choose a reason for hiding this comment

SiarheiFedartsou Jun 6, 2024

Choose a reason for hiding this comment

SiarheiFedartsou commented Jun 9, 2024

SiarheiFedartsou commented Jun 6, 2024 •

edited by github-actions bot

Loading